Michael Grüner

Results 80 comments of Michael Grüner

Hello @mariannasb thanks for your detailed report, as usual. I really appreciate it. I was partially able to reproduce the problem. Here are some findings >So my best guess is...

Hey @mariannasb thank you for your contribution. @mmontero can you take care of this review?

>I would expect that any interpipesrc connected to a live src should use "is-live=true" Indeed that would be my criteria as well. I will get this changed and tested.

@mmontero this one is related to #98

Thanks for the fix @JassonRM . However I don't understand how this fixes the original problem, the buffer is still not available, why isn't the pool allocating new buffers with...

This should also be true for RESTART_TIMESTAMP isn't it?

It was an error, and it got past the reviews. Thanks for adding it.

Thanks! Do you have that change handy enough to make a PR?

@mildsunrise thanks for your contribution, I agree with your suggestion. I've added a couple of my own on your changes.

This seems to be very appropriate. Thanks for the fix, I'll be merging in.