Michael Gregorius

The code in question was added by @Reflexe with commit 723a451ebca as part of #5021.

I think the condition that saves the MIDI port has to be changed from ``` if (Engine::getSong()->isSavingProject() && !Engine::getSong()->getSaveOptions().discardMIDIConnections.value()) ``` to ``` if (!Engine::getSong()->isSavingProject() || (Engine::getSong()->isSavingProject() && !Engine::getSong()->getSaveOptions().discardMIDIConnections.value())) ``` Which...

Thanks for your reply @Reflexe! If I change the line as described above most of the cloning functionality is reestablished except for the state of the custom base velocity LED....

I have created pull request #7066 to fix some of the problems. There seem to be some conceptual issues that have to be clarified before the rest can be fixed.

I have merged pull request #7066. The only remaining problem should be the check box for the custom base velocity which does not seem to have any effect besides disabling...

Pull request #7067 removes/hides the LED check box for the "Custom Base Velocity". Here's how it looks in the current pull request:  However, I'd like to propose to also...

@LostRobotMusic , closing this one as the problem has been fixed. I have created #7195 to deal with potential further adjustments that are mentioned in the comment above.

Hi @BoredGuy1, thanks for your PR! I really like that the Song Editor now defaults to a more zoomed in view! I'd like to propose to use a default quantization...

> Ready for review again. Still looks good to me. @DomClark, @zonkmachine and @Rossmaxx: Is it also good for you? There only seem to be resolved comments now.

Pull request #7271 fixes some performance problems that got introduced by this pull request due to missing initialization of some variables.