Michael Gregorius

Results 192 comments of Michael Gregorius

Thanks for the quick response, @curlymorphic! It's mainly about the lines [299](https://github.com/LMMS/lmms/blob/360254fd81cda14cbcec3fff3dff5456005ebfc8/plugins/Eq/EqEffect.cpp#L299) and [304](https://github.com/LMMS/lmms/blob/360254fd81cda14cbcec3fff3dff5456005ebfc8/plugins/Eq/EqEffect.cpp#L304) in the method [EqEffect::peakBand](https://github.com/LMMS/lmms/blob/360254fd81cda14cbcec3fff3dff5456005ebfc8/plugins/Eq/EqEffect.cpp#L290).

Thanks for the further input @curlymorphic! I will then try to adjust the `Fader` class so that it can be configured to also take dbFS values as input and render...

I have solved this differently now. Instead of extending the `Fader` for this single case I decided to remove the mapping to [0, 1] (or technically rather [0, inf[) that's...

I consider this pull request ready for review and merge now. There are several other things that could be done in separate PRs once this one is merged: * Render...

Thanks for your feedback, @RoxasKH! Most of your points should have been addressed by commit b4bfc7174fa: * It introduces a margin in all directions between the level borders and the...

The failing MSVC builds seem to be a problem with Cloudflare, see [here](https://github.com/actions/runner-images/issues/9476#issuecomment-1987316858).

I have merged the current master to fix the self-inflicted merge conflict that was introduced with my pull request #7141. :sweat_smile: Ready for review. :wink:

Wouldn't this rather be a job for the built-in accessibility tools of the operating system, e.g. the [magnifier](https://support.microsoft.com/en-us/windows/how-to-use-magnifier-reading-59d049ba-8434-9d04-34f2-2e00f11c5cb8)? I think it might be confusing for user with better eyesight to...

The issue is caused by [this line](https://github.com/LMMS/lmms/blob/abe2c92bedbc5e7a16ea4858e94694fc247d9552/src/tracks/InstrumentTrack.cpp#L863) in `InstrumentTrack`. Cloning is implemented via serialization and deserialization of the `Track` (see [here](https://github.com/LMMS/lmms/blob/abe2c92bedbc5e7a16ea4858e94694fc247d9552/src/core/Track.cpp#L164)). However, in the case of cloning `Engine::getSong()->isSavingProject()` will evaluate...