Michael Gregorius

Results 192 comments of Michael Gregorius

With commit 045a2cd5c3f the unity lines are now drawn last.

@he29-net, with commit a644bdcd4f8 there is now a warn range with a solid yellow color. It goes from -6 dbFS to 0 dfBS. I have analyzed the previous implementation (see...

Hi @LMMS/developers, I consider this pull request done now and would like to request a review so that the changes can be merged. Please note that this PR is not...

Hi @he29-net, with commit 99113c3b309 the unity marker now defaults to an opaque color. It is now also possible to style this color via the style sheet. With regards to...

> After [99113c3](https://github.com/LMMS/lmms/commit/99113c3b309cbd10900be8ab7daab1b86be74c6b) the unity line is now pixel-perfect. 👍 Ok, great. :slightly_smiling_face: By the way, I think that screenshot was the ultimate (sub) pixel peeping. :smile: > Maybe (63,...

Hi @RoxasKH, thanks for your feedback! I really appreciate it. With commit 5627384833a I have move the unity marker in the background so that it gets overdrawn when the levels...

@RoxasKH, I have added some commits which render the clipping area as a flat/solid region. The full scale currently looks as follows: ![LevelsWithSolidClipRegion](https://github.com/LMMS/lmms/assets/9293269/0360b9f1-083e-4fb9-98eb-3e266dea26dd) The change also showed that there was...

@PhysSong, do you also want to review this PR? I would greatly appreciate if it would be merged it as it brings several improvements.

> Just a doubt. There seems to be a seperate `EqFader` class which is inherited from the `Fader` class and from what I've heard, it's difference is only the fact...

I have checked the inputs that are used to feed the `EqFader` with peak data. The `EqFader` is used in the following LMMS plugins: * **Compressor:** In and Out *...