Michael Gregorius

Searching for references to `RingBuffer` in the code only yields `MultitapEchoEffect` as a client of that class. So if that plugin could be switched to use `LocklessRingBuffer` then the non-realtime...

~~With regards to my personal taste the slight green somehow "bites" with the other colors. Here's a screenshot of the scroll bar next to the piano:~~  ~~I think in...

> Didn't i change that one to white? Nevermind. I did fetch your changes but it did not pull the branch which I already had checked out previously. So I...

With the border it now feels strange to me when interacting with it. Almost as if it ducks away or does not want to be interacted with: [Screencast_20240414_173854.webm](https://github.com/LMMS/lmms/assets/9293269/9f7fce41-49cf-4788-ad16-1de117f845ee) Personally I'd...

Looks good to me now. Personally I wouldn't add the greenish white either. One last option would be to change the hover color to something between the "passive" gray and...

> The add effect button also feels weird and less clickable now: > > Steps to reproduce: > > * click on add effect -> button color changes while opening...

The problem is fixed by pull request #7237 which extends the `Effect` base class with a new virtual method that can be overridden to react to state changes with regards...

This issue can still be reproduced. One quick way to do so with a stock master was described in #6268: 1. Drag the preset "Kicker/SnareMarch.xpf" into the Song Editor. 2....

Thanks for checking @he29-net! > Some small issues at UHD resolution (2x scale): > > * the Mixer is a bit oversized: each fader is a bit wider (possibly related...

> One even smaller issue: the unity line overlaps with the borders, resulting in bright pixels where they cross: > [snip] I think this might be caused by the order...