samurai icon indicating copy to clipboard operation
samurai copied to clipboard

Allow tabs for indentation

Open prez opened this issue 6 years ago • 2 comments

Currently, attempting to indent key = value pairs with tabs causes expected name errors, which is counter-intuitive. Especially considering that tabs are valid whitespace for line continuation.

The Ninja devs seem to be ignoring this (https://github.com/ninja-build/ninja/issues/1598).

If there is a good reason to reject this, please consider raising an appropriate error message.

Thank you.

prez avatar Dec 01 '19 12:12 prez

Yes, I think that would be quite nice to have, and I see no reason why allowing them would be a problem. Although scripts that use tabs would be incompatible with ninja.

This should be an easy change.

michaelforney avatar Dec 05 '19 05:12 michaelforney

Let's see how ninja will receive my PR https://github.com/ninja-build/ninja/pull/2392 it's just lexer change at the moment

pkitszel avatar Mar 13 '24 23:03 pkitszel