Michael Ficarra
Michael Ficarra
@guybedford > One minor change I'd suggest using `16.2.1.10 GetModuleNamespace ( module, deferred )` with `deferred` as a boolean instead of the `GetModuleNamespace( module, phase )` taking a phase argument,...
Result from editor call today was that we will get rid of `CreateMethodProperty` (it only has one call site) and rename `CreateNonEnumerableDataPropertyOrThrow` to something more appropriate.
It's not even correct, there's also `AsyncArrowFunction` now.
I would prefer to `` "Unicode property name" (and add the qualifier "Unicode" in some cases) to avoid many of these ``s.
We talked about this again in editor call and decided we don't want to refer to Unicode property names or aliases as Unicode properties. So this PR is fine as-is.
The rest pretty much LGTM. This was a lot to review, and the similarity was pretty much only in that they change the same sections. I'd really prefer these get...
> I prefer to keep things together and am happy to perform any necessary git surgery (including removal of any rejected commits), but if carving things up will make review...
> Conversion from anything as if in string concat Also you probably don't want string concat behaviour here. You probably want `String(...)` behaviour, since it won't throw on symbols.
@aapoalas I had something else in mind https://github.com/tc39/ecma262/issues/3475#issuecomment-2881937256
@rkirsling You should have tests where the function is named `async` to cover the case where the cover grammar is used.