CoffeeScriptRedux icon indicating copy to clipboard operation
CoffeeScriptRedux copied to clipboard

update syntastic

Open michaelficarra opened this issue 13 years ago • 8 comments

https://github.com/scrooloose/syntastic/blob/master/syntax_checkers/coffee/coffee.vim

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/85537-update-syntastic?utm_campaign=plugin&utm_content=tracker%2F33145&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F33145&utm_medium=issues&utm_source=github).

michaelficarra avatar Sep 19 '12 21:09 michaelficarra

Hey, I did some work on the syntax checker to get coffee lint support a while back. What needs to change for redux? Maybe I can get it done?

brendanjerwin avatar Feb 05 '13 15:02 brendanjerwin

It should be easy, actually. You pretty much just need to update the file pointed to above to use my compiler's flags instead of the original's. And remove coffeelint. Then just open a pull request and let it sit until this hits 2.0.

michaelficarra avatar Feb 05 '13 17:02 michaelficarra

Why does coffeelint need to be removed?

brendanjerwin avatar Feb 06 '13 01:02 brendanjerwin

coffeelint uses the old compiler, which fails on many perfectly valid constructs. Nested interpolations, for instance.

michaelficarra avatar Feb 06 '13 02:02 michaelficarra

Ok, as of now, the coffeelint and coffeescript compiler checkers are split apart.

Do you think it'll be reasonable/possible to make the coffeescript compiler one automatically sniff out if redux is present?

Maybe a --version test or something?

I'd like to make it "just work" without needing to keep a long-running pull-request up to date.

brendanjerwin avatar Feb 07 '13 14:02 brendanjerwin

Testing --version sounds like an excellent idea.

michaelficarra avatar Feb 07 '13 14:02 michaelficarra

Ok, I'll test for 2.0 in the version output and change the call accordingly.

brendanjerwin avatar Feb 07 '13 14:02 brendanjerwin

Make sure it doesn't misidentify 1.2.0.

michaelficarra avatar Feb 07 '13 14:02 michaelficarra