BeeTee App Icon + Improved Project Structuring

App Icon + Improved Project Structuring

Open cansurmeli opened this issue 6 years ago • 5 comments

May 24 '18 09:05 cansurmeli

Is this project not maintained anymore?

Sep 14 '18 07:09 cansurmeli

Sorry for the delay and thanks for the PR and reminder.

[ ] Are the icons made by you? They are great!
[ ] Can you make the commits smaller and coherent? I have some remarks regarding the coding (such as that I want to avoid shortcuts such as *VC for *ViewController).
[ ] What is your intention to add another layer/subfolder Model?

Sep 17 '18 06:09 michaeldorner

I got the icon from here. Back when I first got the icon, I checked, there were no licensing issues. Checked again now and saw that I didn't miss anything.
Yeah, you're right. It was my laziness. I rebased my fork with smaller/coherent commit logs.
Changed VC to ViewController. As a long time Apple ecosystem developer, I think abbreviations like those are needed but I guess for such an open source project like BeeTee, it's better not to stick to abbreviations.
I think MVC serves well for iOS projects, even though there is a lot of hype now not do so. I think all that's needed is a good grasp on MVC fundamentals and some experience to make it work. So with the structuring I've done, IMHO, it tells what does what more vividly.

Sep 19 '18 17:09 cansurmeli

Thanks for the update and hard work. Can you please clean up the duplicated files in all subfolders?

Sep 27 '18 15:09 michaeldorner

Sorry about the duplicated files. Rebasing. 😐 Should've checked myself.

I also did a Swift 4.2 update but now Travis is reporting a failure!

Sep 29 '18 07:09 cansurmeli