errors on revdep checks for stars

[edzer]

While checking reverse dependencies of stars, I see:

  ══ testthat results  ═══════════════════════════════════════════════════════════
  [ OK: 6 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 3 ]
  1. Failure: SVF calculation is correct (@test_SVF.R#6) 
  2. Failure: SVF calculation is correct (@test_SVF.R#17) 
  3. Failure: SVF calculation is correct (@test_SVF.R#29) 

which seems to boiled down to the fact that SVF now retuns a named vector, which is not equal to an unnamed vector. Please address, or let me know if this is caused by stars!

[michaeldorman]

Thanks @edzer ! The dependency on stars should be removed since the shadow package doesn't use it, I think I added it by mistake... So the issue is almost certainly not caused by stars.

In any case, I can't reproduce the error you reported, either locally or with win-builder. Also couldn't figure out how can the result of SVF be named, in principle. If you can please share your session details, or have any idea what may be different in your settings, I'll greatly appreciate it. Thanks!

sessionInfo()                                                                                                                                                                                          
R version 4.0.3 (2020-10-10)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 20.04.1 LTS

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.9.0
LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.9.0

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C               LC_TIME=en_US.UTF-8        LC_COLLATE=en_US.UTF-8     LC_MONETARY=en_US.UTF-8    LC_MESSAGES=en_US.UTF-8    LC_PAPER=en_US.UTF-8      
 [8] LC_NAME=C                  LC_ADDRESS=C               LC_TELEPHONE=C             LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C       

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] shadow_0.6.9 sp_1.4-4    

loaded via a namespace (and not attached):
 [1] Rcpp_1.0.5           compiler_4.0.3       prettyunits_1.1.1    remotes_2.2.0        tools_4.0.3          testthat_2.3.2       digest_0.6.25        pkgbuild_1.1.0       pkgload_1.1.0       
[10] lattice_0.20-41      memoise_1.1.0        rlang_0.4.8          cli_2.1.0            rstudioapi_0.11      parallel_4.0.3       xopen_1.0.0          xfun_0.18            raster_3.3-13       
[19] withr_2.3.0          stringr_1.4.0        roxygen2_7.1.1       knitr_1.29           xml2_1.3.2           rgeos_0.5-5          desc_1.2.0           fs_1.5.0             devtools_2.3.0      
[28] grid_4.0.3           rprojroot_1.3-2      glue_1.4.2           R6_2.4.1             processx_3.4.4       fansi_0.4.1          rcmdcheck_1.3.3.9000 sessioninfo_1.1.1    callr_3.5.0         
[37] purrr_0.3.4          magrittr_1.5         codetools_0.2-16     backports_1.1.10     ps_1.4.0             ellipsis_0.3.1       usethis_1.6.1        assertthat_0.2.1     stringi_1.5.3       
[46] crayon_1.3.4.9000