Typing icon indicating copy to clipboard operation
Typing copied to clipboard

Can't add new keyboard due to Missing '"' character (OS_X)

Open BenDover178 opened this issue 6 years ago • 3 comments

I'm trying to add a new keyboard to the program (31 keys; adding the apostrophe) but for some reason it won't register. When I try to open tools.c in terminal I get the error messages in the photo. adding keyboard errors It's trying to say there's no ending " character even though there is (and it doesn't look any different compared to the full standard board). Any ideas of what this might be?

BenDover178 avatar Sep 17 '18 21:09 BenDover178

Hi Ben,

Looks like that's because you put an unescaped quotation mark in the middle of the string. You need to put a backslash in front of the quotation mark, so instead of

"qwertyuiopasdfghjkl;'zxcvbnm,./QWERTYUIOPASDFGHJKL:"ZXCVBNM<>?"

it should be

"qwertyuiopasdfghjkl;'zxcvbnm,./QWERTYUIOPASDFGHJKL:"ZXCVBNM<>?"

Hope this fixes your problem.

On Mon, Sep 17, 2018 at 2:56 PM BenDover178 [email protected] wrote:

I'm trying to add a new keyboard to the program (31 keys; adding the apostrophe) but for some reason it won't register. When I try to open tools.c in terminal it shows this:

In file included from tools.c:9: tools.h:69:93: warning: missing terminating " character #define DEFAULT_KEYBOARD_YES "qwertyuiopasdfghjkl;'zxcvbnm,./QWERTYUIOPASDFGHJKL:"ZXCVBNM<>?" ^ In file included from /usr/include/string.h:186, from values.h:18, from tools.h:12, from tools.c:9: tools.c: In function 'initData': tools.h:69:83: error: expected ')' before 'ZXCVBNM' #define DEFAULT_KEYBOARD_YES "qwertyuiopasdfghjkl;'zxcvbnm,./QWERTYUIOPASDFGHJKL:"ZXCVBNM<>?" ^~~~~~~ tools.c:64:56: note: in expansion of macro 'DEFAULT_KEYBOARD_YES' else if (fullKeyboard == K_YES) strcpy(keysToInclude, DEFAULT_KEYBOARD_YES); ^~~~~~~~~~~~~~~~~~~~ tools.h:69:93: error: missing terminating " character #define DEFAULT_KEYBOARD_YES "qwertyuiopasdfghjkl;'zxcvbnm,./QWERTYUIOPASDFGHJKL:"ZXCVBNM<>?" ^ tools.c:64:56: note: in expansion of macro 'DEFAULT_KEYBOARD_YES' else if (fullKeyboard == K_YES) strcpy(keysToInclude, DEFAULT_KEYBOARD_YES); ^~~~~~~~~~~~~~~~~~~~ tools.c:64:34: error: too few arguments to function '__builtin___strcpy_chk' else if (fullKeyboard == K_YES) strcpy(keysToInclude, DEFAULT_KEYBOARD_YES); ^~~~~~ It's trying to say there's no ending " character even though there is (and it doesn't look any different compared to the full standard board). Any ideas of what this might be?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/michaeldickens/Typing/issues/22, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZSqlTqVy4dYz4Z-VjWUesojN95Y5jPks5ucBqAgaJpZM4WszUh .

michaeldickens avatar Sep 17 '18 22:09 michaeldickens

Yes thanks. I guess I just glossed over it for the standard board as an input character.

I tried running the algorithm for a few seconds and it's formatting the layouts like so: Y P O U / K D L C W I N E A ; M H T S R V Q < > ? Z B F G J X y p o u : k d l c w i n e a , m h t s r v q " ' . z b f g j x

Is the key on the bottom supposed to be the apostrophe key? ex: Y P O U / K D L C W I N E A ; M H T S R X V Q < > ? Z B F G J

y p o u : k d l c w i n e a , m h t s r x v q " ' . z b f g j

BenDover178 avatar Sep 17 '18 22:09 BenDover178

Hi Ben, I'm not sure what you changed so I can't say. You can change the way layouts get printed by modifying this function: https://github.com/michaeldickens/Typing/blob/master/keyboard.c

michaeldickens avatar Sep 18 '18 16:09 michaeldickens