devise-pwned_password
devise-pwned_password copied to clipboard
michaelbanfield
Add global enabled option so we can toggle it on and off for different tests
Resolves #30
(Also resolves/supersedes #27)
Currently based on #29 but could be rebased.
- [x] Add tests
- [x] Update docs
It would be nice if we could simply call it Devise::PwnedPassword.enabled, but using top-level Devise config, Devise.pwned_password_check_enabled, seemed to be the most consistent with what this gem is already doing.
Amazing, I was just looking for this!
I have some specific feature specs and VCR recordings that test that devise-pwned_password is working properly, but I only want to selectively enable it for these tests. The with_pwned_password_check test helper is also super awesome, so thanks for including that!
I will use your fork for now and try it out.
UPDATE: This works perfectly! Thanks for your work!
@michaelbanfield Sorry to bother you! But I'm just going through my Gemfile and looking at different forks I'm using, and I'm still using @TylerRick's branch for this PR. I was wondering if it might be possible to merge this and release a new version of the gem?
If you are no longer maintaining the gem, then I'd be happy to take over maintenance and releasing new versions, since my company is using it (https://github.com/docspring).
Update: We're still using this fork and would be keen to see support for this in the official release. But no worries if not!