devise-pwned_password icon indicating copy to clipboard operation
devise-pwned_password copied to clipboard

Published 20 hours ago • verified publisher icon michaelbanfield

Add template methods

Open flori opened this issue 4 years ago • 5 comments

flori avatar Mar 17 '20 10:03 flori

This looks good. Just need to figure out why CI is failing for 2.6: https://github.com/michaelbanfield/devise-pwned_password/pull/26/checks?check_run_id=513421333

TylerRick avatar Apr 24 '20 17:04 TylerRick

Also, may want to call them "callback methods" rather than "template methods"...

TylerRick avatar Apr 24 '20 17:04 TylerRick

I pushed the exact some code up as #34 and it passed CI, which seems to confirm that it's just an intermittent failure. Looks like that also caused the status of this to be updated since they were both associated with the same commit ref (26 and 34).

TylerRick avatar Apr 27 '20 23:04 TylerRick

Also, may want to call them "callback methods" rather than "template methods"...

There is no reference to "template" in the code. We currently run a fork of devise-pwned_password with pretty much this change in it. @TylerRick @michaelbanfield Is there any chance that we get it merged?

  • What I see missing is some mention in the README (although not critical since its a niche feature), I can do that.
  • Also, maybe somebody prefers after_pwned_error instead of pwned_after... (and same for ...attempt...).

fwolfst avatar Aug 02 '22 08:08 fwolfst

Sorry for being pingy, but I'd really like to get this upsteam (and close our fork). Anything I can do to get it back alive?

fwolfst avatar Sep 16 '22 10:09 fwolfst