Michael André Pearce

Results 105 comments of Michael André Pearce

The reason i flag that is that its important from the outset is incase the way the confluent api and proto clients handle it differ to the way you initally...

see PR: https://github.com/hortonworks/registry/pull/458

Please can this be merged if no comments has been open nearly a month now.

@satishd sure, will add a test case in the coming week, thanks for the review.

Why not store and present as the schema as json form e.g. like .proto files, it would then be more align with how we are doing avro using a json...

There is some complexity to add to client side, to support dynamically registering by capturing the schema from the generic message. Not both apicur.io and confluent schema registry in adding...

Go look at confluents code its there, also theres a jsonformatter in proto ;)

Also remember will need client side support. And obviously the key bit would be to auto register a Message (as like avro) where it gets the schema from the object....

Lastly something to think about. Is that its actually possible to convert a protobuf to avro (and likewise schema) it be good to support that in registry. E.g use case...

@harshach @satishd could you review please