Michael Osipov

Results 569 comments of Michael Osipov

The only thing I can image is that `String` will contain a local path to a proprties file. But I really would put this issue aside until someone really complains...

This should not be default for two reasons: * It will apply a significant computational overhead * Artifacts which have been locally installied don't have checksums at all

What is the purpose of this PR if the issue has been resolved?

None with ServiceLocator. furnace-maven-plugin will be broken. but I do t care.

> > > Another strange thing I just now realized: if you look at `org.eclipse.aether.impl.guice.AetherModule`, bindings are in `Singleton` scope. But, if you look at corresponding classes, they have `@Named`...

Please note that Maven Core uses this stupid locator too: https://github.com/apache/maven/blob/39641ac803e17360df40288aaeb40ea0c5ccd77d/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionResolver.java.

@cstamas I have added few more commits here. Please have a look too. Preparing a Maven branch for testing...

> > > LGTM, thanks. As per comment on MRESOLVER-157, I think this should NOT be merged until 1.7.0 is out (as on master.`ServiceLocator` is already deprecated). Agreed. This is...

@splatch Your proposal is to move the Guice/Sisu binding to a separate module to have more control over for non-DI users?