Michael Osipov
Michael Osipov
Why not use our Validate class?
> > > These are factory methods, they don't validate anything. There are several spots you have changed which are subject to conditions and can use `Validate`.
I think this is wrong. the `name` shall remain as is. In a future version of the POM we will add something for SPDX. Therefore, I'd recommend to modify the...
> > > @michael-o I think it would make sense to re-write the docs when a SPDX field is added, but right now, the docs say to put SPDX into...
> Which color do you want to paint the bikeshed? :-) > > I prefer option 2 (consistent indent) but doing this two different ways for calls and declarations is...
Change looks good.
Much simpler to read now...
Will likely happen either this Friday or in 10 days. I think this should not be in Maven 3.9.0 just to avoid any breakings.
> Any updates on this PR? Can we expect it to be merged soon? > > I'm a contributor of [JDT Language Server](https://github.com/eclipse/eclipse.jdt.ls), and one of our core component [m2e](https://github.com/eclipse-m2e/m2e-core)...
> > Proper evaluation I'd mandatory > > I understand and appreciate all the work you guys have done. If I remember clearly, some integration tests and details were discussed...