Michael Erickson

Results 12 issues of Michael Erickson

**sql/stats: replace eval.Context with tree.CompareContext** Most uses of eval.Context in the sql/stats package can actually be tree.CompareContext instead, so make the replacement. Release note: None **sql/stats: bump histogram version to...

When generating statistics forecasts, we must pick a time at which to forecast. To make forecasts deterministic, this time must be based on only the existing collected statistics for the...

backport-22.2.x

Michael Erickson (michae2) commented: In 23.2, under read committed isolation, applications could still encounter spurious 40001 errors in rare cases, such as lease transfers. In 24.1, under read committed isolation,...

Michael Erickson (michae2) commented: When upgrading from 23.2 to 24.1, cluster setting `sql.txn.read_committed_isolation.enabled` will be enabled by default, meaning transactions started with `BEGIN TRANSACTION ISOLATION LEVEL READ COMMITTED` will actually...

CatchVectorizedRuntimeError performs its stack-walking in order to catch *all* panics originating from within the vectorized execution engine, including runtime panics. The purpose of this is to limit the impact of...

In 23.1 we added the ability to collect redacted statement diagnostics bundles using `EXPLAIN ANALYZE (DEBUG, REDACT)` which was tracked by https://github.com/cockroachdb/cockroach/issues/68570 and https://github.com/cockroachdb/cockroach/issues/98817. In order to make collection of...

C-enhancement
O-support
A-sql-ui
A-sql-explain
A-sql-debug-bundle
A-observability-inf
P-3
T-observability

With the new SFU implementation (`optimizer_use_lock_op_for_serializable`) we now simplify cardinality=0 input to norows, but we still add the lock on top. We should be able to simplify this to norows....

C-performance
A-sql-optimizer
T-sql-queries
A-read-committed

**sql: add defensive type check to sql.(\*optTableStat).init** In statistics builder we assume that the datums decoded from histogram upper bounds are comparable with datums in spans and constraints. If the...

backport-23.1.x
backport-23.2.x
backport-24.1.x
backport-23.2.6-rc

In `sql/row/kv_batch_fetcher.go` there are trace messages that print the Scan or Get operation. We should add locking information to these for better observability of SELECT FOR UPDATE and other locking...

C-enhancement
O-qa
A-sql-execution
T-sql-queries
E-quick-win
A-read-committed
P-3