Michael Erickson comments

Results 39 comments of


                                            Michael Erickson

sql: add SHOW STATISTICS WITH FORECAST

bors r+

sql: cluster setting for early/late binding in udf body

Thank you for doing this!

sql: cluster setting for early/late binding in udf body

@chengxiong-ruan makes sense. If it's alright with you, I'm going to open an issue about late vs early binding, with some of the examples from the RFC discussion, so that...

sql: cluster setting for early/late binding in udf body

Ok, filed #89109.

lint: add a linter to prohibit map[...]bool in favor of map[...]struct{}

I'm generally in favor. As you say there are cases where the trinary logic of `map[...]bool` is actually needed, so it would be nice to have some kind of "nolint"...

*: rename SQL Stats

Reopening because there was confusion from a customer about this.

opt: collect stats for virtual computed columns

Also see https://github.com/cockroachdb/cockroach/issues/85176 and https://github.com/cockroachdb/cockroach/issues/78181 which are similar.

opt: collect stats for virtual computed columns

Another example of this coming up with an expression index: ```sql CREATE TABLE t (i INT PRIMARY KEY, j JSONB); INSERT INTO t SELECT i, json_build_object('a', i % 10) FROM...

sql: automatic way to ensure new sql keyword is added to `bare_label_keywords` list

Maybe some kind of test that automatically tries to parse `SELECT 1 ` with every (unreserved) keyword would suffice?

sql: partial predicate evaluation fails for newly added columns

Based on #96337 it looks like this might also happen with user-defined types used in partial indexes, not just columns.