Michael Denny

Results 52 comments of Michael Denny

> I'm unable reproduce the original issue with the integration tests. I'll have to go back and dig deeper. ok no pressure, take your time 😄 but I would like...

maybe `SanitiseName` is already used everywhere? BTW just check that this fix has been spread whenever is needed, thanks 🙇

@mijabr do you have time to implement this using `WebUtility.UrlEncode(....);` instead of `SanitiseName(...)`?

@inikulshin if you found the error in the source code, a PR will be much appreciated, thank you 😄

> Please run `dotnet format` on your code Sorry if I didn't run it, I read the contributing guidelines but the command was for old dotnet format, sdk 6 now...

> using the latest sdk 6.x it doesn't complain or change anything I was wrong saying that it didn't change anything, because in fact has fixed a couple of space

> Hello @micdenny, > Do you think your PR should fix this use case ? @NightFox7 I'm going to try it adding it to this branch and pushing run :)...

@asbjornu some CI test are failing but I don't understand why: ![image](https://user-images.githubusercontent.com/1633595/189912735-a8134786-05c3-43e9-94d4-21e8d627a8a7.png)

> Hello @micdenny, Do you think your PR should fix this use case ? @NightFox7 unfortunately it does not solve that problem 😞 ``` Message:  Shouldly.ShouldAssertException : variables.FullSemVer should be...

@asbjornu I've closed all the proposed changes, are you happy with this PR? I don't understand what some tests are complaining about: > unknown test file type for 'artifacts/test-results/GitVersion.MsBuild.Tests.netcoreapp3.1.results.xml'