Michael Denny

Results 52 comments of Michael Denny

Would be great to have this included in the semver library, enabled by default as when you serialize the classic old `Version` class

Why the [`Version`](https://github.com/dotnet/runtime/blob/master/src/libraries/System.Private.CoreLib/src/System/Version.cs) class is serialized as excepted? Probably is a known type of Newtonsoft Json library and there is a default converter for it?

I will try to re-run the issue with newer version, I didn't clone a repo from azdo, the test case I've submitted it's a vanilla git repository created exactly with...

I've re-run it the exact same repro steps with version `5.10.3+Branch.support-5.x.Sha.bc9c9d003e655385e3dd1ba3bd013e04062d2f9b` and it does the same `dotnet gitversion /nocache /output json /output buildserver` ``` INFO [09/08/22 20:03:32:73] Working directory: C:\temp\gittools-bug\local-case1...

@asbjornu I manage to create a repro as fixture here: - https://github.com/micdenny/GitVersion/tree/issue/3020/repro - https://github.com/GitTools/GitVersion/compare/5.10.3...micdenny:GitVersion:issue/3020/repro?expand=1

Even because if you check the OnlyLocal test it is just working fine, the remote version instead doesn't work, so there's should be a subtle bug somewhere

> @micdenny, If I change the `increment` strategy to `Patch` for `pull-request`, your remote test passes. Sorry @asbjornu, I don't get how this can help me, pull-request has to follow...

> Setting `increment` explicitly to `Patch` makes both tests succeed. yes, but then if we add a test closing the PR against `main` setting `increment` to `patch`, that test will...

I figure out where the problem is, but not why: ![image](https://user-images.githubusercontent.com/1633595/189732998-98a45607-220c-4b62-b471-dc9cda1c3a33.png) in somehow the remote is messing up probably with the `LocalRemoteBranchEqualityComparer`, because in the `excludedInheritBranches` there is the `hotfix/v1.0.2`...

It is not `LocalRemoteBranchEqualityComparer`, but it's the `this.repositoryStore.ExcludingBranches(excludedInheritBranches)` and the "why" resides in this equality/comparer lambdas ![image](https://user-images.githubusercontent.com/1633595/189836475-c93fbabe-3d7d-4bae-a7ff-03ab3d5cdbd3.png) I would not change this behavior, probably you want to know that `origin/main`...