react-native-slider icon indicating copy to clipboard operation
react-native-slider copied to clipboard

Published 20 hours ago • verified publisher icon miblanchard

feat: Customisable right padding of the track after maximumValue

Open RobertMetcalfePhorest opened this issue 2 years ago • 1 comments

Description

This PR addresses the issue described here: https://github.com/miblanchard/react-native-slider/issues/345

The proposed solution consists of adding a property that will let users specify the trackRightPadding instead of always using the thumbSize.width

Before

Screenshot_2022-08-08_at_14_16_12

After

Screenshot 2022-08-08 at 14 15 42

RobertMetcalfePhorest avatar Aug 08 '22 13:08 RobertMetcalfePhorest

This is a super basic feature, how is this still not adressed ? Can we prioritize this issue ?

hugoh59 avatar Aug 17 '22 07:08 hugoh59

Is this going to be merged soon?

brycnguyen avatar Dec 08 '22 22:12 brycnguyen

@RobertMetcalfePhorest - Looks like there are some merge conflicts now. Can you resolve? Then I will merge and publish.

miblanchard avatar Dec 28 '22 00:12 miblanchard

Great fix! When will this be merged?

mikespence avatar Feb 23 '23 10:02 mikespence

@mikespence - We need @RobertMetcalfePhorest to resolve the merge conflicts before we can merge.

miblanchard avatar Feb 24 '23 18:02 miblanchard

@miblanchard Resolved the conflict

RobertMetcalfePhorest avatar Apr 05 '23 11:04 RobertMetcalfePhorest

Can this be merged please?

nbodesa avatar May 02 '23 20:05 nbodesa

@miblanchard I still have this issue, I have downloaded version 2.3.1 and its still there. Or should i do something else to fix this issue?

MattinNajafi avatar May 15 '23 19:05 MattinNajafi

When this PR release? I also have this troble with 2.3.1

voidsatisfaction avatar Jun 29 '23 03:06 voidsatisfaction