FeedWriter icon indicating copy to clipboard operation
FeedWriter copied to clipboard

Published 20 hours ago • verified publisher icon mibe

Refactoring Suggestion

Open FreebieStock opened this issue 12 years ago • 1 comments

Each feed type should be a separate class, instead of checking all the time what type of feed it is:

if($type == 'RSS 1') ... elseif($type == 'RSS 2')

elseif($type == 'Atom')

This is not the OOP way.

FreebieStock avatar Feb 12 '13 20:02 FreebieStock

You're right, this is indeed not the OOP way. There's some discussion on this topic in #3 also. Patches are always welcome. :smile:

mibe avatar Feb 25 '13 23:02 mibe