qrm2
qrm2 copied to clipboard
Multiple typing issues
This is an issue to list all currently found typing and typing-related issues in qrm that will require refactoring, or depend on Bolt features..
-
[ ] 1. Mypy is mad each time we access
bot.qrmor a member of such -
[ ] 2. Mypy is mad when we set a
categoryin the command/group decorator -
[ ] 6. Error handling: mypy is angry that we try to append something to
embed.description -
[ ] 7. globalchannelconverter: yells that a method is missing yet present from class
-
[ ] 8. "": "TYPE MISMATCH"
Those are the easy to fix ones
- [x] 3. extctl: Mypy does not like that we call the result of get_command(), perhaps we could call it directly
- [x] 4. add_react(): the type is too strict
- [x] 5. error handling: ctx.invoked_with could be None
- [x] 9. embedfactory: mypy does not like like directly passing ctx.author as text=
- [x] 10. addreact: none has no id
Breaking up into another issue: #289