qrm2 icon indicating copy to clipboard operation
qrm2 copied to clipboard

Multiple typing issues

Open 0x5c opened this issue 5 years ago • 1 comments

This is an issue to list all currently found typing and typing-related issues in qrm that will require refactoring, or depend on Bolt features..

  • [ ] 1. Mypy is mad each time we access bot.qrm or a member of such

  • [ ] 2. Mypy is mad when we set a category in the command/group decorator

  • [ ] 6. Error handling: mypy is angry that we try to append something to embed.description

  • [ ] 7. globalchannelconverter: yells that a method is missing yet present from class

  • [ ] 8. "": "TYPE MISMATCH"

0x5c avatar Oct 28 '20 23:10 0x5c

Those are the easy to fix ones

  • [x] 3. extctl: Mypy does not like that we call the result of get_command(), perhaps we could call it directly
  • [x] 4. add_react(): the type is too strict
  • [x] 5. error handling: ctx.invoked_with could be None
  • [x] 9. embedfactory: mypy does not like like directly passing ctx.author as text=
  • [x] 10. addreact: none has no id

Breaking up into another issue: #289

0x5c avatar Oct 29 '20 02:10 0x5c