SODS icon indicating copy to clipboard operation
SODS copied to clipboard

Linked values, line breaks issue and naming fixes

Open ideas-into-software opened this issue 2 years ago • 5 comments
trafficstars

  • Added support for linked values, i.e. linking cell value to a sheet, file, URI or URL

  • Fixed bug with cell values which contain line separators - setting those via both office:string-value attribute and text:p element results in office:string-value taking precedence and text displayed containing no line breaks

  • Added BND instruction to include sources in OSGi jar

  • Fixed spelling mistake in OdsWriter naming

  • Bumped version to 1.5.3

ideas-into-software avatar Mar 26 '23 19:03 ideas-into-software

Thanks!

I am confused with the 2 PR... So is this the right one?

miachm avatar Mar 26 '23 22:03 miachm

Hi Miguel,

Yes, this (#63) is the PR I would ask you review and merge.

The other PR (https://github.com/miachm/SODS/pull/62) was closed in favor of this PR, which contains both (bug fixes as well as support for linked values).

Thanks!

I am confused with the 2 PR... So is this the right one?

ideas-into-software avatar Mar 27 '23 10:03 ideas-into-software

@miachm does anything speaks against merging the current state of this? We'd really like to use this and it would be great if we could just use a Version from maven Central instead of one from our own fork.

juergen-albert avatar Jan 16 '24 12:01 juergen-albert

@juergen-albert I think I just forgot about it. Now it need to fix the conflicts t.t, but yes, it can be added to the next version.

miachm avatar Jan 17 '24 23:01 miachm

This is highly appreciated. If you need a hand, just reach out.

juergen-albert avatar Jan 19 '24 10:01 juergen-albert