3696 prevent top navigation group text overflow
fix top navigation group labels overflowing
fix #3696
Summary of the changes
Tell us, in a few words, what the changes are.
Related issue
Tell us the issue number. If suggesting an improvement or component, please discuss it with us in an issue first.
Checklist
General
- [x] Changes to docs package checked and committed.
- [x] All acceptance criteria reviewed and met.
Testing
- [x] Relevant unit tests and visual regression tests added.
- [x] Visual testing against Figma component specification completed.
- [x] Playground stories in React Storybook up to date, with any prop changes and additions addressed.
- [x] Compare performance of modified components against develop using Performance addon in React Storybook.
Accessibility
- [x] Accessibility Insights FastPass performed.
- [x] A11y unit test added and yields no issues.
- [x] A11y plug-in on Storybook yields no issues.
- [x] Manual screen reader testing performed using NVDA and VoiceOver.
- [x] Manual keyboard testing for keyboard controls and logical focus order.
- [x] Correct roles used and ARIA attributes used correctly where required.
- [x] Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.
Resize/zoom behaviour
- [x] Page can be zoomed to 400% with no loss of content.
- [x] Screen magnifier used with no issues.
- [x] Text resized to 200% with no loss of content.
- [x] Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.
System modes
- [x] Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
- [x] Windows High Contrast mode tested with no loss of content.
- [x] System light and dark mode tested with no loss of content.
- [x] Browser support tested (Chrome, Safari, Firefox and Edge).
Testing content extremes
- [x] Min/max content examples tested with no loss of content or overflow.
- [x] All prop combinations work without issue.
- [x] Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
- [x] Controlled and uncontrolled input components tested.
- [x] Props/slots can be updated after initial render.
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/3696-top-navigation-group-overflow/web-components View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/3696-top-navigation-group-overflow/react
Cypress visual tests failed. View the image diff here: https://github.com/mi6/ic-ui-kit/tree/gh-pages/branches/3696-top-navigation-group-overflow/cypress-image-diff-screenshots/diff View the html report here: https://mi6.github.io/ic-ui-kit/branches/3696-top-navigation-group-overflow/cypress-image-diff-html-report/cypress-image-diff-html-report.html
Looks like you've got to rebase off latest develop to clear those audit problems?