ic-ui-kit icon indicating copy to clipboard operation
ic-ui-kit copied to clipboard

1948 ic textfield focus overlapping

Open GCHQ-Developer-773 opened this issue 1 year ago • 4 comments

Summary of the changes

Change to the input label css to allow for space between the helper and focus when the focus is used.

Related issue

Issue 1948 https://github.com/mi6/ic-ui-kit/issues/1948

Checklist

General

  • [x] Changes to docs package checked and committed.
  • [x] All acceptance criteria reviewed and met.

Testing

  • [x] Relevant unit tests and visual regression tests added.
  • [x] Visual testing against Figma component specification completed.
  • [x] Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • [x] Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • [x] Accessibility Insights FastPass performed.
  • [x] A11y unit test added and yields no issues.
  • [x] A11y plug-in on Storybook yields no issues.
  • [x] Manual screen reader testing performed using NVDA and VoiceOver.
  • [x] Manual keyboard testing for keyboard controls and logical focus order.
  • [x] Correct roles used and ARIA attributes used correctly where required.
  • [x] Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • [x] Page can be zoomed to 400% with no loss of content.
  • [x] Screen magnifier used with no issues.
  • [x] Text resized to 200% with no loss of content.
  • [x] Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • [x] Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • [x] Windows High Contrast mode tested with no loss of content.
  • [x] System light and dark mode tested with no loss of content.
  • [x] Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • [x] Min/max content examples tested with no loss of content or overflow.
  • [x] All prop combinations work without issue.
  • [x] Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • [x] Controlled and uncontrolled input components tested.
  • [x] Props/slots can be updated after initial render.

GCHQ-Developer-773 avatar Sep 25 '24 09:09 GCHQ-Developer-773

View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1948-ic-textfield-focus-overlapping/web-components View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1948-ic-textfield-focus-overlapping/react

github-actions[bot] avatar Sep 25 '24 09:09 github-actions[bot]

Your PR was set to target main, PRs should be target develop The base branch of this PR has been automatically changed to develop, please check that there are no merge conflicts

github-actions[bot] avatar Sep 25 '24 09:09 github-actions[bot]

Cypress visual tests failed. View the image diff here: https://github.com/mi6/ic-ui-kit/tree/gh-pages/branches/1948-ic-textfield-focus-overlapping/cypress-image-diff-screenshots/diff View the html report here: https://mi6.github.io/ic-ui-kit/branches/1948-ic-textfield-focus-overlapping/cypress-image-diff-html-report/cypress-image-diff-html-report.html

github-actions[bot] avatar Sep 25 '24 10:09 github-actions[bot]

If possible, please merge the react commits together. Please also make your commit messages more descriptive of the components affected and add a summary and related ticket to the description of this PR

GCHQ-Developer-112 avatar Sep 25 '24 15:09 GCHQ-Developer-112

The baseline images need to be regenerated on the CI, there shouldn't be any need to increase the regression threshold for extra padding.

Also mirror @GCHQ-Developer-299 some components now have too large a gap, can you localise these changes to Search/Select and Text Field?

gd2910 avatar Oct 16 '24 10:10 gd2910