ic-ui-kit icon indicating copy to clipboard operation
ic-ui-kit copied to clipboard

fix(web-components): breadcrumb group collapsed prop issue

Open lz405 opened this issue 1 year ago • 2 comments

Fixed the issue with the breadcrumb group collapsed prop not toggling properly and fixed the back arrow not turning back into a chevron

fix #1998 fix #2028

Summary of the changes

Fixed the issue where the breadcrumb group prop would, when toggled, not remove the collapsed ellipses element so they would just stack up Also fixed the issue where, when toggled back and forth, the back arrow for the 'back breadcrumb only' prop would not switch back to a chevron icon

Related issue

#1998 #2028

lz405 avatar Sep 12 '24 14:09 lz405

View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/bugfix/1998-ic-breadcrumb-group-collapsed-prop/web-components View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/bugfix/1998-ic-breadcrumb-group-collapsed-prop/react View your NextJs branch deployment here: https://mi6.github.io/ic-ui-kit/branches/bugfix/1998-ic-breadcrumb-group-collapsed-prop/nextjs

github-actions[bot] avatar Sep 12 '24 14:09 github-actions[bot]

I'm getting some odd behaviour on the collapsed state still, but I think it's a weird edge case. If I toggle in the side panel, it works fine, but when the toggle is set to collapsed="true" and then I click the ellipsis, and set collapsed to "false" in the side panel again, it completely removes breadcrumb 2. It could just be a storybook nuance, but it'd be good if there was a way the playground collapsed value could reflect the actual collapsed value if the ellipsis is clicked e.g. updating the switch to false if the ellipsis is clicked.

https://github.com/user-attachments/assets/eaf8110a-8b6e-447f-9ed4-94da47a84253

GCHQ-Developer-530 avatar Sep 13 '24 13:09 GCHQ-Developer-530