ic-ui-kit icon indicating copy to clipboard operation
ic-ui-kit copied to clipboard

[ic-textfield] Focus is overlapping the label / description

Open GCHQ-Developer-465 opened this issue 1 year ago • 3 comments

Summary of the bug

The focus on the textfield is overlapping the label/description. This effects many of the components which are inheriting the component.

📸 Screenshots or code

Screenshot 2024-06-03 at 16 06 59

🧐 Expected behaviour

There should be extra padding around the component so that this bug does not occur.

Additional info

Designs on Figma should be looked at.

GCHQ-Developer-465 avatar Jun 03 '24 15:06 GCHQ-Developer-465

Worth considering if the field looks unusual when the focus is not applied, presuming the fix is to increase padding. Design to implement this on Figma

MI6-255 avatar Jul 26 '24 08:07 MI6-255

this looks to have more padding in figma, so just needs a change making to the built component to match

figma on the left, built component on the right: image

ad9242 avatar Aug 14 '24 11:08 ad9242

https://github.com/mi6/ic-ui-kit/issues/2301

MI6-255 avatar Aug 15 '24 08:08 MI6-255