ic-ui-kit icon indicating copy to clipboard operation
ic-ui-kit copied to clipboard

1817 Make tests consistent and removal of status tags depreciated story for pr checklist

Open GCHQ-Developer-465 opened this issue 1 year ago • 2 comments

Summary of the changes

Removal of status tags depreciated story.

Make all the tests consistent with phrasing by adding should.

Related issue

#1817

Checklist

General

  • [x] Changes to docs package checked and committed.
  • [x] All acceptance criteria reviewed and met.

Testing

  • [x] Relevant unit tests and visual regression tests added.
  • [x] Visual testing against Figma component specification completed.

Accessibility

  • [x] Accessibility Insights FastPass performed.
  • [x] A11y unit test added and yields no issues.
  • [x] A11y plug-in on Storybook yields no issues.
  • [x] Manual screen reader testing performed using NVDA and VoiceOver.
  • [x] Manual keyboard testing for keyboard controls and logical focus order.
  • [x] Correct roles used and ARIA attributes used correctly where required.
  • [x] Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • [x] Page can be zoomed to 400% with no loss of content.
  • [x] Screen magnifier used with no issues.
  • [x] Text resized to 200% with no loss of content.
  • [x] Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • [x] Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • [x] Windows High Contrast mode tested with no loss of content.
  • [x] System light and dark mode tested with no loss of content.
  • [x] Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • [x] Min/max content examples tested with no loss of content or overflow.
  • [x] All prop combinations work without issue.
  • [x] Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • [x] Controlled and uncontrolled input components tested.

GCHQ-Developer-465 avatar May 22 '24 08:05 GCHQ-Developer-465

Your PR was set to target main, PRs should be target develop The base branch of this PR has been automatically changed to develop, please check that there are no merge conflicts

github-actions[bot] avatar May 22 '24 08:05 github-actions[bot]

Cypress visual tests failed. View the image diff here: https://github.com/mi6/ic-ui-kit/tree/gh-pages/branches/1817-component-pr-checklist/cypress-image-diff-screenshots View the html report here: https://github.com/mi6/ic-ui-kit/tree/gh-pages/branches/1817-component-pr-checklist/cypress-image-diff-html-report

github-actions[bot] avatar May 22 '24 10:05 github-actions[bot]

I think if we're making updates to the test descriptions it'd be good to tidy up some of the other issues with them! This looks much better though, love the consistency

Thanks 😊 Sorry, what do you mean when you say 'some other issues' can you please specify?

GCHQ-Developer-465 avatar May 23 '24 11:05 GCHQ-Developer-465

I think if we're making updates to the test descriptions it'd be good to tidy up some of the other issues with them! This looks much better though, love the consistency

Thanks 😊 Sorry, what do you mean when you say 'some other issues' can you please specify?

Just the ones I've requested changes for - spelling mistakes and capitalisation in the wrong places etc.

GCHQ-Developer-530 avatar May 23 '24 12:05 GCHQ-Developer-530

I think if we're making updates to the test descriptions it'd be good to tidy up some of the other issues with them! This looks much better though, love the consistency

Thanks 😊 Sorry, what do you mean when you say 'some other issues' can you please specify?

Just the ones I've requested changes for - spelling mistakes and capitalisation in the wrong places etc.

No problem. Just some minor changes then! :D

In regards to the capitals, i reflected on changes in pervious PRs and changed them in this one. However I am going back to them and changing as they are naming conventions of components 👍

GCHQ-Developer-465 avatar May 23 '24 12:05 GCHQ-Developer-465