ic-ui-kit icon indicating copy to clipboard operation
ic-ui-kit copied to clipboard

Add height and width prop to ic-skeleton

Open gd2910 opened this issue 1 year ago • 1 comments

Summary

Currently, changing height and width directly (can be set via child element) on the ic-skeleton can only be set with inline styling. This can be confusing if a developer is trying to style using CSS classes. Adding a height and width prop would bring the component more in line with how our other components are consumed.

  • [ ] Add height and width props to component
  • [ ] Add Playground to Skeleton's react Storybook (to contribute to #1970)

💬 Description

As above, adding these props should not constitute a breaking change.

💰 Use value

Help developers use the ui-kit in a more standardised way.

📝 Acceptance Criteria

If relevant, describe in full detail the different interactions and edge cases that the component or patterns needs to fulfil.

Given a height/width prop is set When Using ic-skeleton with direct styling Then The height and width are changed

gd2910 avatar May 02 '24 15:05 gd2910

this has been requested again by a customer team as it would make migrating from MUI easier (as it has props for width and height)

ad9242 avatar Jun 12 '25 11:06 ad9242