ic-ui-kit icon indicating copy to clipboard operation
ic-ui-kit copied to clipboard

Date time input

Open GCHQ-Developer-539 opened this issue 1 year ago โ€ข 9 comments

Summary

Tell us, in a few words, what the component or pattern would do.

๐Ÿ’ฌ Description

A full description of what the component or pattern should be and how it should work.

๐Ÿ’ฐ User value

Describe why this is important and how it will help users (either developers, designers or the end-users). Think about how it makes people's lives easier, more accessible or quicker to build stuff.

๐Ÿ“š User Stories

If relevant, describe the high-level functionality as user stories.

As an ICDS user:
I need So that

๐Ÿ“ Acceptance Criteria

If relevant, describe in full detail the different interactions and edge cases that the component or patterns needs to fulfil.

Given When
Then

โœ Designs

If there's a Figma design file (or other mock-up), include it here.

##โ€ฏ๐Ÿงพ Guidance If there's written guidance or documentation, include a link to it here.

Additional info

Tell us anything else useful to help us understand your suggestion.

GCHQ-Developer-539 avatar Mar 06 '24 09:03 GCHQ-Developer-539

https://github.com/mi6/ic-ui-kit/issues/3962 raised to cover enhancements needed to time input & picker for milliseconds, am\pm & time zone support which is needed before developing date-time components

ad9242 avatar Sep 18 '25 13:09 ad9242

Good news! Datetime input change to allow for milliseconds is relatively easy...simple change to helper text and placeholder text to include MMS (milliseconds).

Bad news; Datetime input does not utilise a calendar view and as such the existing AM/PM selector (available on time picker) cannot easily be incorporated into this single-line input field. Will need to come up with an approach that uses the same styling (as on the picker) but works when placed alongside a single input field.

mi6-577 avatar Sep 19 '25 07:09 mi6-577

Time zone support to come under separate ticket #3980

mi6-577 avatar Sep 26 '25 11:09 mi6-577

In Figma, it looks like this has been done under one single branch for datetime picker and datetime input.

Will endeavour to unpick and get datetime input into canary area (as per timeinput) since these are the most simple of the changes to make.

mi6-577 avatar Sep 26 '25 11:09 mi6-577

Have merged initial change for datetime input into canary area, so at least we're on an equal footing with time input.

Will have to wait for time input to settle before continuing with datetime input...we need to use the same AMPM toggle, so it might be worthwhile moving that toggle somewhere central (possibly under atoms)

mi6-577 avatar Sep 26 '25 11:09 mi6-577

Left to do:

  • update Atoms/date status on datetime input component ...is out of date with latest changes
  • update datetime input to include AM/PM toggle as per time input

mi6-577 avatar Oct 15 '25 07:10 mi6-577

Datetime input has been modified (as per time input) as per previous comment - this is now in the main Figma branch

mi6-577 avatar Nov 10 '25 10:11 mi6-577

Separate ticket to be raised for guidance Moving this to in refinement

mi6-577 avatar Nov 10 '25 10:11 mi6-577

Minor question raised around Reflow (how will this field handle being limited to 320px)

GCHQ-Developer-299 avatar Nov 13 '25 09:11 GCHQ-Developer-299