ic-design-system icon indicating copy to clipboard operation
ic-design-system copied to clipboard
verified publisher icon mi6

docs(root): added semantic typography

Open MI6-94 opened this issue 1 year ago • 3 comments

added semantic typography

MI6-94 avatar May 17 '24 14:05 MI6-94

View your branch deployment here: https://mi6.github.io/ic-design-system-githubpages/branches/927-typography-include-semantic-elements-in-code-examples

github-actions[bot] avatar May 17 '24 14:05 github-actions[bot]

Curious side effect here (testing out your branch locally on left, live site on right) where the headings have large margins when you have semantic elements inside them Screenshot 2024-05-17 at 15 34 14

GCHQ-Developer-299 avatar May 17 '24 14:05 GCHQ-Developer-299

as @GCHQ-Developer-299, says there seems to be a problem. I think it is to do with the way the site substitutes <H1>etc for ic-typography elements. so there are nested elements when you inspect the code:

image

ad9242 avatar May 17 '24 14:05 ad9242

This work is covered in the Stackblitz ticket already and could cause conflicts. I believe this PR should be closed

GCHQ-Developer-112 avatar May 21 '24 10:05 GCHQ-Developer-112

Closing for the reason above

GCHQ-Developer-112 avatar May 21 '24 14:05 GCHQ-Developer-112