ic-design-system icon indicating copy to clipboard operation
ic-design-system copied to clipboard

The table on the "Auditory needs" page has border gaps between each column

Open GCHQ-Developer-112 opened this issue 1 year ago • 4 comments

Summary of the bug

The table under the "Example of hearing impairments" on the "Auditory needs" page has border gaps between each column which seems inconsistent with the design of other pages

🪜 How to reproduce

Navigate to the "Accessibility" navigation item In the left hand nav, open up the "accessibility needs" accordion Select the "Auditory needs" page and scroll down to the "Examples of hearing impairments" heading

📸 Screenshots or code

Screenshot 2025-01-07 at 08 51 29

🖥 📱 Device

  • Type: Desktop
  • Device: MacBook
  • Browser version: Chrome 131

🧐 Expected behaviour

The assumption is that there should be no border gaps between columns, however this should be checked with design first

GCHQ-Developer-112 avatar Jan 07 '25 08:01 GCHQ-Developer-112

seems to be an issue with the way mdx gets converted to table. it only applies the border on the td elements, not the tr

ad9242 avatar Feb 06 '25 12:02 ad9242

Proposal: provide a CSS fix in the Design System (rather than modifying the underlying MDX)

GCHQ-Developer-299 avatar Feb 07 '25 10:02 GCHQ-Developer-299

A wrapped component in the overrides could help: https://github.com/mi6/ic-design-system/blob/main/src/components/WrappedAlert/index.tsx

MI6-255 avatar Feb 27 '25 10:02 MI6-255

fix seems to be to set border-spacing: 0 on the table, but need to find a way to apply this to potentially only the markdown generated tables, which converts the following format to a table:

Image

ad9242 avatar Feb 27 '25 10:02 ad9242