ic-design-system icon indicating copy to clipboard operation
ic-design-system copied to clipboard

docs(root): replaced fig2 in date picker guidance

Open srt544 opened this issue 1 year ago • 6 comments

Replaced fig2 in date picker

Tell us, in a few words, what the changes are. Replaced fig2 in date picker guidance with correct image

Tell us the issue number. If suggesting an improvement or component, please discuss it with us in an issue first.

#1041

srt544 avatar Sep 06 '24 13:09 srt544

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 06 '24 13:09 CLAassistant

View your branch deployment here: https://mi6.github.io/ic-design-system-githubpages/branches/bugfix/1041-update-date-picker-guidance-images

github-actions[bot] avatar Sep 06 '24 13:09 github-actions[bot]

Review the high definition quality of the image against the others, slightly blurry. This should be exported from Figma as 'x2 PNG'.

MI6-94 avatar Sep 17 '24 13:09 MI6-94

Do the dates in the final image also need changed, or is this the correct behaviour?

GCHQ-Developer-094 avatar Sep 24 '24 10:09 GCHQ-Developer-094

Review the high definition quality of the image against the others, slightly blurry. This should be exported from Figma as 'x2 PNG'.

I have noticed and have now replaced it with a higher resolution image

srt544 avatar Oct 04 '24 15:10 srt544

Do the dates in the final image also need changed, or is this the correct behaviour?

According to the issue the final image is correct.- The only image needing correction was fig2.

srt544 avatar Oct 04 '24 15:10 srt544

These images also need updating;

image

Date input should read - 29/07/2024

image

Date picker year should read 2023, as this date would be in the past and invalid

gd2910 avatar Oct 16 '24 13:10 gd2910

These images also need updating;

image

Date input should read - 29/07/2024

image

Date picker year should read 2023, as this date would be in the past and invalid

Updated the images on Design 😊

GCHQ-Developer-465 avatar Oct 16 '24 15:10 GCHQ-Developer-465