tinysoap icon indicating copy to clipboard operation
tinysoap copied to clipboard

tinysoap-browser-min.js problem running with requirejs.org

Open hhkaos opened this issue 3 years ago • 0 comments

Hi there!,

First of all, thank you for the amazing work you have done! 💪 .

I'm just opening this issue because I have been playing around with this library and I have noticed there is a problem at the begging of the script. When it checks if typeof require === undefined while the requirejs library is loaded it fails because it tries to load NodeJS core modules.

Would it make sense to replace that condition for something like this: if (typeof window === 'undefined')? If you think it does I'll be have to send a PR.

You can see more at this thread

Best regards, Raul

hhkaos avatar Aug 06 '20 13:08 hhkaos