dwarfs icon indicating copy to clipboard operation
dwarfs copied to clipboard

unbundling

Open Alessandro-Barbieri opened this issue 3 years ago • 9 comments

Please provide a way to unbundle folly, fbthrift, fsst and parallel-hashmap. I'm packaging this for gentoo and I'll really appreciate

Alessandro-Barbieri avatar May 01 '21 07:05 Alessandro-Barbieri

Hi @Alessandro-Barbieri,

Are you aware of https://gpo.zugaina.org/Overlays/guru/sys-fs/dwarfs? This is maintained by @RarogCmex.

What's your plan for the dependencies? Are you planning to maintain folly, fbthrift, etc as separate ebuilds?

I can definitely support external versions for all these libraries, similar to zstd & xxHash. Is that what you're looking for?

mhx avatar May 01 '21 13:05 mhx

Good daytime all! At this moment I experienced some…well, adventures with russian military enlistment office, so I can't make that ebuilds this time. I even think about the resign my maintainership. However, @Alessandro-Barbieri , if you do that, I'll send you my applauses :)

vlcsnap-2021-05-01-18h58m45s718

RarogCmex avatar May 01 '21 13:05 RarogCmex

I've already made all the ebuilds for the dependencies except for parallel-hashmap (soon I'll make one for that)

Alessandro-Barbieri avatar May 01 '21 14:05 Alessandro-Barbieri

Now on guru there are

  • folly (with exception_tracer)
  • fbthrift
  • wangle
  • parallel_hashmap
  • fizz

Alessandro-Barbieri avatar May 02 '21 01:05 Alessandro-Barbieri

I can definitely support external versions for all these libraries, similar to zstd & xxHash. Is that what you're looking for?

Yes

Alessandro-Barbieri avatar Jul 10 '21 07:07 Alessandro-Barbieri

Good day everyone! What is current status of unbundling in 0.6.1? @Alessandro-Barbieri Could you update your patchset?

RarogCmex avatar Jun 14 '22 06:06 RarogCmex

I've just pushed an unbundling branch. This has new options PREFER_SYSTEM_PARALLEL_HASHMAP and PREFER_SYSTEM_FOLLY.

There's no PREFER_SYSTEM_FBTHRIFT yet, because I'd like to get the other stuff working before tackling thrift. The current issues are that dev-cpp/folly is too old for thrift to build. I just made my own folly ebuild for 2022.06.06.00 and with that, I can compile dwarfs. However, linking currently fails because folly's folly-config.cmake introduces a linker dependency on gflags_shared.

Please feel free to investigate further based on this branch.

mhx avatar Jun 18 '22 05:06 mhx

Could you share that ebuild?

Alessandro-Barbieri avatar Jul 02 '22 01:07 Alessandro-Barbieri

https://gist.github.com/mhx/fc93326bd7e5c91cf7fffcdf68bef9b6

(TBH, I think I just renamed the file that's in the package index, so "my own ebuild" was probably a bit exaggerated.)

mhx avatar Jul 04 '22 11:07 mhx

Is there anything left to do here? I'm closing this for now, please feel free to reopen if this isn't done yet.

mhx avatar Oct 29 '22 20:10 mhx