Martin Hutchinson

Results 37 comments of Martin Hutchinson

Hah, I've just spent ages messing about with looking into the linters and go versions. The answer appears to be as simple as running go build to find the root...

Root cause is probably https://github.com/kubernetes/client-go/issues/1084. @vaikas can I leave this with you?

Error is ``` Already have image (with digest): gcr.io/trillian-opensource-ci/trillian_testbase running gofmt running goimports running golangci-lint level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package version: could not load...

These are partially documented at https://github.com/google/trillian/blob/master/docs/Feature_Implementation_Matrix.md and this would benefit from fleshing out. See #1845 for an example of uncertainty and issues around specific versions of DB.

I'm going to tidy up the feature implementation matrix and call this done.

@zoeylee02 - did you try this, and did it work? We'll close this issue if we don't get any updates soon.

/gcbrun I've just rebased this to fix conflicts in the go.mod file

This is currently failing presubmit checks because `klog.Fatalf` is not recognized as an exit condition, and we're getting staticcheck errors from this. This is fixed (https://github.com/dominikh/go-tools/pull/1110) but we'll need to...

I've got #2791 to update to the latest linter, but it doesn't fix this problem. https://github.com/dominikh/go-tools/blob/v0.3.3/go/ir/exits.go#L100 - looks like more work is required upstream in the staticcheck library to detect...