vscode-git-graph icon indicating copy to clipboard operation
vscode-git-graph copied to clipboard

Interactive rebase does not work inside VSCode dev container

Open samherrmann opened this issue 2 years ago • 0 comments

Describe the Bug Interactive Git rebase does not work inside a VSCode development container when initiated through Git Graph and with VSCode set as Git's editor, i.e. core.editor=code --wait

Steps to Reproduce Steps to reproduce the behaviour:

  1. Open a Git project inside a VSCode dev container.
  2. Ensure core.editor=code --wait is set (Run git config --list from inside the dev container).
  3. In Git Graph, right-click on a previous commit and select Rebase current branch to this Commit...
  4. In the next popup dialog, select Launch Interactive Rebase in new Terminal and click the Yes, rebase button.
  5. Observe the expected git-rebase-todo file not opening and the following error output in the terminal:
    git rebase --interactive <git-hash>
    hint: Waiting for your editor to close the file... code or code-insiders is not installed
    error: There was a problem with the editor 'code --wait'.
    
  6. Now run git rebase --interactive <git-hash> in a new VSCode terminal (still inside the dev container).
  7. Observe VSCode successfully opening the git-rebase-todo file.

Expected Behaviour I expected the git-rebase-todo file to open successfully when initiating the Git rebase from Git Graph.

Environment

  • Git Graph Extension Version: [e.g. 1.30.0]
  • Visual Studio Code Version: [e.g. 1.67.1]
  • Operating System: Windows 10 => WSL2 => Ubuntu 20.04

samherrmann avatar May 20 '22 14:05 samherrmann