vscode-git-graph icon indicating copy to clipboard operation
vscode-git-graph copied to clipboard

fix(web): fix create file tree error when folder named constructor.

Open pavlelee opened this issue 3 years ago • 1 comments

Issue Number / Link: No

Summary of the issue:

If a directory in a project is called constructor, Commit Detail View always show loading.

Description outlining how this pull request resolves the issue:

normal directory: wecom-temp-2906404db59352c0d3af4970639f575a

wrong directory: wecom-temp-c7238f180e89d58b3c9942008bfaee2a wecom-temp-e06f45d2280e4e1698ff14bb90e1de61

because constructor and JS constructor have the same name: wecom-temp-f4f09d961f5262a7f7bacc2c5cc467d9

After modification: image image

pavlelee avatar Mar 23 '22 10:03 pavlelee

probably should use !Object.prototype.hasOwnProperty.call(cur.contents, path[j])

maxisam avatar Nov 26 '24 04:11 maxisam