vscode-git-graph
vscode-git-graph copied to clipboard
mhutchie
"View Diff" should open VS Code's rich diff viewer for Jupyter Notebooks
Describe the improvement that you'd like VS Code has a native diff viewer for Jupyter notebook files. This is the default diff view when you select "Show Changes" on a notebook file in the Source Control sidebar. However, Git Graph's "View Diff" feature opens the diff of the raw text file, which is generally not useful. Git Graph should use the same diff view that VS Code uses.
Additional context (optional)
This is what a notebook diff looks like:
It would be great if someone could take a look at this. Currently, it makes viewing changes in commits in data-science repositories impossible using the git-graph extension.
I have tried to find the issue, but unfortunately, I'm unfamiliar with Javascript / Typescript.
It seems like git-graph executes the command vscode.diff, just like the Open Changes context option from the default source control panel. So the issue is likely in the parameters passed to that command.
I don't have time to actually try this out, but after a bit of digging it looks like git-graph is passing the diff command URIs with 'git-graph' as the scheme (https://github.com/mhutchie/vscode-git-graph/blob/develop/src/diffDocProvider.ts#L140), whereas the built-in source control pane uses 'git' as the scheme (https://github.com/microsoft/vscode/blob/main/extensions/git/src/uri.ts#L30)
