yaml-sort-checker icon indicating copy to clipboard operation
yaml-sort-checker copied to clipboard

WIP: Feature: scan dirs

Open rmikalkenas opened this issue 4 years ago • 3 comments

Issue: #5

Using symfony finder component I have managed to implement ability to define directories in config files in which yml/yaml files would be found for checking.

Remaining question: currently all files inherit options defined by directory. Maybe it would be useful to exclude files from scanning if they are defined in config file? For example: if config file contains app/config: and next line app/config/services.yml, then I think we should exclude services.yml file from scanned files in app/config directory and use options defined under that concrete file.

rmikalkenas avatar Sep 10 '20 20:09 rmikalkenas

@mhujer ping :)

rmikalkenas avatar Sep 13 '20 18:09 rmikalkenas

@rmikalkenas Hi! Thanks for the PR, but I'm sorry, I'm not using this tool anymore, so I can't review this. (The reason is that the Symfony configs are now split into many small files where sorting is less useful - I keep them sorted logically instead),

But AFAIK @OndraM has been using yaml sort checker, so maybe he will find some time to review this.

mhujer avatar Sep 13 '20 20:09 mhujer

@rmikalkenas Hello, maybe I will behave as asshole but I have library for yaml standards too and that library knows to find all .yaml/.yml/.yml.dist/.yaml.dist in directory but it's true it doesn't know to exclude keys from alphabetical check (yet). So, if you are interested you can check it out.

sspooky13 avatar Sep 24 '20 12:09 sspooky13