galois icon indicating copy to clipboard operation
galois copied to clipboard

Add support for NumPy >= 2.1

Open Francis-dev82 opened this issue 1 year ago • 5 comments

Francis-dev82 avatar Sep 05 '24 14:09 Francis-dev82

Do you know if this is a big change to the code base? I am sure you have other priorities just curious what the timeline might be.

Francis-dev82 avatar Sep 05 '24 15:09 Francis-dev82

I'm sure it's just bumping the max version in pyproject.toml and submitting a PR. I could maybe do it this evening.

mhostetter avatar Sep 05 '24 15:09 mhostetter

fwiw, galois 0.4.2 still does not support numpy 2.1 - because numba 0.60 requires numpy<2.1

Also fwiw I suggest that 2.2 is an odd upper bound for this library to choose for numpy. Do you have reason to expect that 2.2 will be breaking?

I expect that in practice numba will always be the bottleneck on the numpy version that galois can use, so you might as well not bother with an upper bound at all.

dimbleby avatar Sep 07 '24 18:09 dimbleby

Numba is working on this. Hopefully we will know more after the developer meeting tomorrow. https://github.com/numba/numba/issues/9708

Francis-dev82 avatar Sep 09 '24 13:09 Francis-dev82

fwiw, galois 0.4.2 still does not support numpy 2.1 - because numba 0.60 requires numpy<2.1

Thanks for pointing this out. I rushed to close the PR and didn't do due diligence.

Also fwiw I suggest that 2.2 is an odd upper bound for this library to choose for numpy. Do you have reason to expect that 2.2 will be breaking? I expect that in practice numba will always be the bottleneck on the numpy version that galois can use, so you might as well not bother with an upper bound at all.

I think this is a very reasonable idea. I'll incorporate that change when I add support for Numba 0.61.

mhostetter avatar Sep 09 '24 13:09 mhostetter