Martin Hombach

Results 43 comments of Martin Hombach

I can confirm for the current version, for us the test is skipped if the test-title is contains something like this with those special quotes inside ```js it('should trigger `onChange`...

@MrPickles2009 If it's just "untrustworthy" I guess that's ok. I would be more concerned if it flags the dll as malicious, because that would mean that we should change something...

@melloware is this issue solved for you? If so, please close it :)

Ah, thx for linking the PR :)

@Tyrrrz Hey, any news on this issue? :)

I can now confirm it has to do with https://github.com/facebook/jest/issues/6645 : ```js const testMock = { works: jest.fn().mockImplementation(() => Promise.resolve(undefined)), fails: jest.fn().mockResolvedValue(undefined), }; it('test-mockImplementation', fakeAsync(async() => { console.log(new Promise(() =>...

Any chance this issue will be verified and tackled? It's an easy reproducible bug which should be also somewhat-eaasy to fix.

Update: Following a longer discussion on this issue: https://github.com/facebook/jest/issues/6645 The https://github.com/facebook/jest/issues/6645 tried to fix the problem, but (to my impression) failed to do so. It added this unit-test (https://github.com/SimenB/jest/blob/464b45a015f98485d4037f1b4d4c5da750e39890/e2e/mock-functions/__tests__/index.js) to...

@SimenB any feedback on this? Again, my assumption is that the fix you implemented does not work and the unit tests added are not passing and just silently erroring out.