Matt Holt comments

Results 1992 comments of


                                            Matt Holt

caddy.go: Check whether @id is unique

I feel like a better approach would be to check the ID as it's being read in and we're creating the mapping of IDs to their full config paths. If...

Setting default_sni to a value that won't generate a cert can cause memory exhaustion

Hmm, I'm not really sure what to do about this though. We can't know you made a mistake like that, I don't think... I'm also not really sure what that...

Setting default_sni to a value that won't generate a cert can cause memory exhaustion

I see, so that one function is using 9.8 GB instantaneously (i.e. not cumulatively)? That does seem like a problem... could you grab a profile? https://caddyserver.com/docs/profiling -- heap and goroutine...

Setting default_sni to a value that won't generate a cert can cause memory exhaustion

Yeah, profiles are technically safe to share.

Setting default_sni to a value that won't generate a cert can cause memory exhaustion

Thanks, I'll take a look!

Dependency fixes and updates to development process

I'm not a fan of Makefiles in Go projects :sweat_smile: but as long as it's optional and just your preference I guess that's OK :man_shrugging: :+1: Any reason in particular...

Dependency fixes and updates to development process

Well, the versions in go.mod of libraries don't really matter (AFAIK), since, in the case of Caddy plugins, the versions used are determined by Caddy's go.mod. @francislavoie and @mohammed90 understand...

Dependency fixes and updates to development process

2.7 is an old version though. The go.mod in this repo doesn't dictate what version of quic-go gets used (unless it needs an old version, AFAIK). It's the go.mod in...

False positive for functions in map

Possibly a duplicate of #40 This really needs to be fixed. Putting `nolint` everywhere is defeating the purpose, so I will probably be uninstalling the linter.

Difficulty finding information on "global variables"

Great feedback, thank you. The new docs will probably structure things differently and hopefully make them more discoverable/obvious.