Matt Holt comments

Results 1992 comments of


                                            Matt Holt

proxy: make a few methods public

I see, you're embedding the Handler type and then writing your own methods that get promoted over the embedded one's, but you still call the embedded Handler's method and are...

proxy: make a few methods public

Ah, sorry, I got busy with the rest of my backlog.

An equivalent of Apache's +ExportCertData in Caddy

Thanks -- to clarify, it looks like, based on the forum topic, the request is actually for placeholders containing server cert info.

An equivalent of Apache's +ExportCertData in Caddy

Ah, that's because in the header directive(s) only _known_ placeholders are replaced. If there is no client certificate, the placeholder is not set. We can change this in one of...

An equivalent of Apache's +ExportCertData in Caddy

Thanks for the workaround @steffenbusch ! I suppose we could still change the placeholders behavior in the case of client auth missing.

An equivalent of Apache's +ExportCertData in Caddy

As far as I know, it is not being worked on by anyone yet.

An equivalent of Apache's +ExportCertData in Caddy

I would start in here: https://github.com/caddyserver/caddy/blob/1bd567d7ad41d5509e2aa60cf36e749f195ad83c/modules/caddyhttp/replacer.go#L399-L492

An equivalent of Apache's +ExportCertData in Caddy

Yeah, already have some of those; I would stick to just the few that this issue is requesting, but even before that, if you want, we can make this adjustment:...

Make add/remove package commands idempotent

I agree. How would you feel about changing this patch to not perform the task if the build is not different?

update quic-go to v0.52.0

Thanks! That's exciting! I bet we'll need to update our code to be compatible. @WeidiDeng Do you have an idea of what we'll need to update to support graceful shutdowns...