Matt Holt
Matt Holt
Thanks -- yeah, maybe we can make exactly what the DecisionFunc guards configurable.
Caddy does not buffer responses unless there is special processing required -- this usually requires explicit configuration (for example, the `templates` middleware requires a buffered response body so it can...
@brotbert Dependabot broke the build; my follow-up commit fixed the build except for those using old caddy versions apparently. The latest commit actually makes it work for old Caddy versions...
Likely fixed already, based on a commit just a few months ago. https://github.com/caddyserver/caddy/issues/5976
Upstream bug: https://github.com/golang/go/issues/56494
(as noted in the forum, the cleanup bug is fixed in https://github.com/caddyserver/certmagic/commit/23ca487b74f7b42a414d0442c2f57d95ab90e0a5)
Oh... yeah, edge case. That is just a little more complicated than I wanted to do at the time. So if we're going to fix that we'll need to decide...
> I recently came across the capability of using Starlark scripting with Caddy This was discussed at one time, about 5 years ago, but as far as I know never...
Nice work cranking through this! :) I'll circle back after the 2.8 release.
Also probably open a new issue with enough information to reproduce the bug :+1: