Matt Holt

Results 1518 comments of Matt Holt

Awesome. FWIW if you go to [the git history for that file](https://github.com/caddyserver/caddy/commits/2b8d1b1517f98da775465b59e0372a8d9efbd027/modules/caddyhttp/fileserver/staticfiles.go), this commit shows up: https://github.com/caddyserver/caddy/commit/8848df9c5d372a559d01512b7a4ef00e38867b55 Where I revert a commit that did attempt to preserve the QS. Here's...

@jaygooby Thanks for working on this, I'm trying to circle back around very soon and inspect this carefully.

Superseded by #6109. Thank you for helping to get this started! Sorry it took me so long.

We'll probably tag 2.7 beta 2 in a few moments -- if this isn't ready before the release candidate (or stable, whichever comes first), might just bump this back to...

Well, I'm not sure if a new `list-plugins` command is the right answer -- maybe it is. I need to think about it more, or maybe have a discussion about...

I think this is the same as #5254. Unfortunately this is sensitive code and I haven't had a chance to properly review it yet. I don't think it'll make it...

Thanks for proposing this Francis, I'll try to get around to reviewing this soon. (Sorry for the delay. I'm also curious about this versus #5504)

Looking good, but my remaining concern is closing the request body. The std lib will close the original request body, I guess, and we don't need to close the new...