mholt
Added include/exclude lists for IP ranges, which plugins can opt-into using
This PR may be controversial as it's not backwards compatible with existing ip_source plugins, I'm happy to take a different approach if there's pushback.
This is to address https://github.com/mholt/caddy-dynamicdns/issues/74
The issue was for adding some sort of config switch to enable private IPs using the interface plugin to support e.g. internal services or split-horizon DNS setups. I've tried to generalise this in two ways:
- Supporting IP range / subnet includes/excludes subsumes this and may be useful in its own right.
- Factored out into the root dynamicdns plugin settings so that other ip_source plugins can opt-in. (I noticed that IPVersions already works this way.)
Thanks for the PR -- sorry, I've been a bit too busy to review it lately.
It's on my list to circle back to it, but if anyone else would like to do a review in the meantime I'd welcome it!
Sorry for letting this languish for so long! I hope it's not too much effort to re-review this to remind yourself what the heck I was trying to do here.
Sorry -- what a year. Just one thing that doesn't quite sit right with me, and it's a very little thing I admit, but curious if you agree and then we can move forward on it 👍
I do agree, no problem at all, I'm sure you've had much more important things to do than this little PR :) appreciate your time