PapaParse icon indicating copy to clipboard operation
PapaParse copied to clipboard

Published 20 hours ago • verified publisher icon mholt

Added option quoteDataWithSpaces (default - true) to unparse config.

Open alexander-gush opened this issue 5 years ago • 5 comments

If quoteDataWithSpaces set to false, unparse result doesn't quote data with spaces in the start or in the end.

alexander-gush avatar Oct 08 '20 08:10 alexander-gush

Hi @alexander-gush,

Thanks for your pull request. Could you please explain why this feature is usefull? In order to accept a PR we require to have a minimal test on our test suite that ensures that your behaviour works as expected. Could you please add one?

pokoli avatar Oct 08 '20 08:10 pokoli

Thank you! Some times it may be unexpectedly that quotes appears in output but there are not in input. So I think we should give possibility to control it. I added test.

alexander-gush avatar Oct 08 '20 09:10 alexander-gush

We are still missing the doc update (which is in the docs folder of the repository) to include the new option

pokoli avatar Oct 09 '20 19:10 pokoli

We are still missing the doc update (which is in the docs folder of the repository) to include the new option

I added this option to the documentation.

alexander-gush avatar Oct 12 '20 12:10 alexander-gush

Hi @alexander-gush,

There are some conflicts with the master branch. Could you plesae rebase your work on top on it and fix them?

Thanks in advance!

pokoli avatar Mar 14 '22 09:03 pokoli