vim-grepper icon indicating copy to clipboard operation
vim-grepper copied to clipboard

Fix file completion

Open blueyed opened this issue 7 years ago • 2 comments

Please see the commits for details.

blueyed avatar Mar 01 '18 00:03 blueyed

What does the first commit fix in the "foo " case? I can't see any difference.

Currently the completion doesn't seem to handle files with whitespaces. But checking against path should be correct in that case as it tries to complete a second file.

And I'm no fan of the vint changes. Replacing " by two ' for no good reason just makes the code more unreadable. Just leave away style changes. :>

It would be cool if you would use one commit per change. It's kind of hard to follow otherwise. And :Gblame is more useful afterwards, since you can quickly see why the code was changed.

mhinz avatar Mar 01 '18 11:03 mhinz

Changed the vint changes.. for the map expr you can use "'foo'", i.e. double quotes for the outer level. What about a .vintrc.yaml?

policies:
  ProhibitEqualTildeOperator:
    enabled: false
  ProhibitUnnecessaryDoubleQuote:
    enabled: false

(although I would prefer to fix them)

Will have to revisit this PR / answer your comments, but might take a while.

blueyed avatar Mar 14 '18 00:03 blueyed